[FIX] OWMap: minor fixes #2356
Merged
[FIX] OWMap: minor fixes #2356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2356 +/- ##
==========================================
- Coverage 73.39% 73.35% -0.04%
==========================================
Files 317 317
Lines 55582 55597 +15
==========================================
- Hits 40792 40782 -10
- Misses 14790 14815 +25 |
|
This works for the workflow we talked about. However, the widget crashes when I connect it to a data set without any numerical features (say, bookexcerpts.tab), open GeoMap and press 'zoom in' function. Also it is constantly printing out all the tokens from the 'Unable to set ComboBox' error. Perhaps just something to keep the console clean? |
|
Thanks. Please see again. |
|
This is good! I like the changes. But again, what to do regarding the checks? |
kernc
force-pushed
the
owmap
branch
2 times, most recently
from
3745df4
to
5613816
Compare
* when data subset is input and data input is cleared * on dataset w/ no latlon features when zoom-to-fit
lanzagar
approved these changes
Jun 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Geo Map crashed when data input, then subset input, then data input cleared.
Geo Map showed warning when setting DomainModel-controlled master value attributes to None.
Description of changes
Neither of above should happen.
Includes