[FIX] Silhouette Plot: handling memory error #2336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kernc
reviewed
May 23, 2017
| self.assertFalse(self.widget.Error.memory_error.is_shown()) | ||
| with unittest.mock.patch( | ||
| "numpy.asarray", | ||
| side_effect=MemoryError): |
There was a problem hiding this comment.
Can you test this without mocking?
There was a problem hiding this comment.
So that we see the exception is caught. Which is not the case if such an exception state arises in e.g. an unguarded C code.
janezd
reviewed
May 23, 2017
| self.assertFalse(self.widget.Error.memory_error.is_shown()) | ||
| with unittest.mock.patch( | ||
| "numpy.asarray", | ||
| side_effect=MemoryError): |
| GH-2336 | ||
| """ | ||
| from Orange.data import Table | ||
| import unittest |
There was a problem hiding this comment.
Forgotten to move those two lines up.
Codecov Report
@@ Coverage Diff @@
## master #2336 +/- ##
==========================================
+ Coverage 73.36% 73.36% +<.01%
==========================================
Files 317 317
Lines 55586 55607 +21
==========================================
+ Hits 40778 40797 +19
- Misses 14808 14810 +2 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Memory error.
Description of changes
Includes