[FIX] Settings: check for attributes before comparing #2258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerneju
changed the title
|
Why would there be a context that does not have attributes? |
Codecov Report
@@ Coverage Diff @@
## master #2258 +/- ##
=======================================
Coverage 72.47% 72.47%
=======================================
Files 319 319
Lines 55130 55130
=======================================
Hits 39958 39958
Misses 15172 15172 |
|
Context handlers should be allowed to assume that the context is of the correct kind. The right way to approach this should be fixing the offending widget, which is (although at the moment incorrectly) being done in #2254. Let's continue the discussion there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://sentry.io/biolab/orange3/issues/256593225/
Description of changes
Includes