[FIX] Loading iris on C locale #1998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failing test on windows seems related to the change. Can you take a look? |
…_FR.UTF-8??? Fixes biolab#1997
Codecov Report@@ Coverage Diff @@
## master #1998 +/- ##
=======================================
Coverage 89.52% 89.52%
=======================================
Files 91 91
Lines 9200 9200
=======================================
Hits 8236 8236
Misses 964 964Continue to review full report at Codecov.
|
|
Indeed, encoding should be set also when writing the file. Thanks. |
astaric
added a commit
to astaric/orange3
that referenced
this pull request
Feb 14, 2017
[FIX] Loading iris on C locale (cherry picked from commit 992d6fd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#1997
Description of changes
Load *.metadata as UTF-8. Additionally, fix reporting filename and filetype in OWFile.
Includes