[FIX] Evaluation Results input validation #1954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If present then bail out early and show a error message.
janezd
approved these changes
Feb 3, 2017
| if nan_values: | ||
| self.Error.invalid_values() | ||
| else: | ||
| self.Error.invalid_values.clear() |
There was a problem hiding this comment.
No need to change anything here, but just if you didn't know: if you prefer, you can use self.Error.invalid_values(shown=nan_values), which shows or hides the messages.
astaric
pushed a commit
that referenced
this pull request
Feb 3, 2017
…ation [FIX] Evaluation Results input validation (cherry picked from commit 5cbac0e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Most widget in evaluation category fail when presented either an empty Evaluation Results instance or one containing nan values. The source of these is in most cases the 'Predictions' widget.
Description of changes
Includes