-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OWNomogram: Add a new widget #1936
Conversation
Current coverage is 89.51% (diff: 100%)@@ master #1936 diff @@
==========================================
Files 90 90
Lines 9180 9182 +2
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 8219 8219
- Misses 961 963 +2
Partials 0 0
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of suggestions:
- Some difference in the font for Points/Total/Probabilities vs. feature names would be very welcome. I think just changing feature names to not be bold would already make the visualization easier and quicker to process.
- Log. Reg. models always use
align left
(setting disabled). And for Naive Bayes, center alignment will mostly be used. I suggest removing this setting completely, and just selecting this automatically based on the classifier. - I suggest removing the option
Variance
in Sort by. Together with absolute importance they are a bit redundant, as the latter incorporates it to a degree anyway - a variable can't distinguish classes well without enough variance. Variance of a variable is also not readable from this visualization (unlike other measures) and should be investigated somewhere else (box plot?). - A better default would probably be to show the top 10 most informative variables (absolute importance). All and unsorted is probably going to be changed very quickly and every time for data with tens of variables or more.
- I was not yet able to figure out what the
Continuous features:
option is used for? It is disabled for data with discrete and/or continuous features. Total
andProbabilities
appear as separate graphical elements. IMHO it would be better to either:
a) Have them actually be separate. In this case Probabilities could be on a linear scale from 0 to 1. (points not aligned)
b) Use one line and one point, with values for Total/Prob. shown above/below.
c) Keep two separate scales, but make it more clear they are connected by a small vertical line going through both (aligned) points.
With b) and c) users are less likely to look only at Prob. (while changing feature sliders) and be confused by some peculiarities (like the cutoff and a deformed scale). Adding <= and >= to the first and last value could also help.
@janezd Could you please confirm the above suggestions? |
80abbf7
to
61de7e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We noticed some bugs with @VesnaT yesterday, which she began fixing. When she confirms that is finished I am in favour of merging, and doing improvements in new PRs afterwards. |
c505f78
to
77abd43
Compare
Issue
Description of changes
Includes