[FIX] Select Rows filter enum #1854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ales-erjavec
force-pushed
the
fixes/select-rows-enum-use
branch
from
aaf594c
to
aa90832
Compare
PyQt5 5.7.1 on PyPi falsely advertises python 3.4 support
Insert the widget into the view before setting filter values. Ensure (somewhat) more consistent view of the state if/when conditions_changed is invoked from `set_new_values`
ales-erjavec
force-pushed
the
fixes/select-rows-enum-use
branch
from
aa90832
to
6b001f6
Compare
Current coverage is 89.21% (diff: 100%)@@ master #1854 diff @@
==========================================
Files 86 86
Lines 9077 9077
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 8097 8098 +1
+ Misses 980 979 -1
Partials 0 0
|
|
Travis complains on an unrelated test and this fixes a vital issue. Could @lanzagar please check and merge asap? Thanks! |
lanzagar
approved these changes
Jan 4, 2017
astaric
pushed a commit
to astaric/orange3
that referenced
this pull request
Jan 4, 2017
…um-use [FIX] Select Rows filter enum
astaric
pushed a commit
to astaric/orange3
that referenced
this pull request
Jan 4, 2017
…um-use [FIX] Select Rows filter enum
astaric
pushed a commit
to astaric/orange3
that referenced
this pull request
Jan 4, 2017
…um-use [FIX] Select Rows filter enum
astaric
pushed a commit
to astaric/orange3
that referenced
this pull request
Jan 6, 2017
…um-use [FIX] Select Rows filter enum (cherry picked from commit d9fcfed)
astaric
pushed a commit
to astaric/orange3
that referenced
this pull request
Jan 10, 2017
…um-use [FIX] Select Rows filter enum (cherry picked from commit d9fcfed)
astaric
pushed a commit
to astaric/orange3
that referenced
this pull request
Jan 11, 2017
…um-use [FIX] Select Rows filter enum (cherry picked from commit d9fcfed)
astaric
pushed a commit
to astaric/orange3
that referenced
this pull request
Jan 13, 2017
…um-use [FIX] Select Rows filter enum (cherry picked from commit d9fcfed)
astaric
pushed a commit
to astaric/orange3
that referenced
this pull request
Jan 18, 2017
…um-use [FIX] Select Rows filter enum (cherry picked from commit d9fcfed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The widget was broken since 60e1369 which changed the filter type enums.
Description of changes
Use proper Filter{Continuous,String}.Type enums for constructing filters.
Includes