Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Scatter Plot: Fix a error when restoring from pre DomainModel workflows #1672

Merged
merged 1 commit into from
Oct 28, 2016

Conversation

ales-erjavec
Copy link
Contributor

@ales-erjavec ales-erjavec commented Oct 18, 2016

... when the attr_* were stored by name.

For example open the second workflow (Interactive Visualizations) in the 'MenuBar->Help->Examples'

@codecov-io
Copy link

Current coverage is 89.38% (diff: 100%)

Merging #1672 into master will not change coverage

@@             master      #1672   diff @@
==========================================
  Files            79         79          
  Lines          8589       8589          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           7677       7677          
  Misses          912        912          
  Partials          0          0          

Sunburst

Powered by Codecov. Last update 4d1ea03...dd7bd9c

@janezd
Copy link
Contributor

janezd commented Oct 18, 2016

I knew that #1608 breaks compatibility, but decided against introducing legacy patches.

I changed my mind. I don't oppose to adding this PR. Yet this example shows we need a general solution. 7e454bd is going to create the same problem in Sieve.

I suppose we need settings versions and a method OWWidget.settings_migration(old_settings) that returns migrated settings (or patches the given setting in-place). The method would be called before settings are applied to the widget. Classes like DomainContextHandler would provide utility functions such as those in this PR. @astaric?

janezd
janezd previously requested changes Oct 21, 2016
Copy link
Contributor

@janezd janezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wait with merging this; I will try to refactor it into a more general solution. Give me one day.

@astaric
Copy link
Member

astaric commented Oct 28, 2016

One day is gone. A general solution turned out to be more complicated. While it may come at a later time, I am merging this now as it fixes a known bug.

@astaric astaric dismissed janezd’s stale review October 28, 2016 11:29

The general solution turned out more complicated and will be done at a later date.

@astaric astaric merged commit 30c3f54 into biolab:master Oct 28, 2016
@astaric astaric modified the milestone: 3.3.9 Nov 28, 2016
@ales-erjavec ales-erjavec deleted the scatter-plot-restore-settings branch January 27, 2017 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants