[FIX] OWBoxPlot: Fix crash with missing values #1640
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 88.70% (diff: 100%)@@ master #1640 diff @@
==========================================
Files 78 78
Lines 8148 8148
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 7227 7228 +1
+ Misses 921 920 -1
Partials 0 0
|
VesnaT
changed the title
kernc
suggested changes
Oct 7, 2016
| data = self.iris | ||
| data.X[:, 0] = np.nan | ||
| self.send_signal("Data", data) | ||
| self.assertEqual(self.widget.dataset, data) |
There was a problem hiding this comment.
Why are we testing this?? dataset is set to whatever is passed in on the signal, so, yes, this is equal. It's also implementation dependent and proves nothing.
There was a problem hiding this comment.
Point je, da tak assert lahko passa, widget pa niti približno ne dela, torej zavaja. Nimate pojma.
VesnaT
changed the title
|
Continued in #1647 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1568