Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] ImageLoader - Avoid using http cache when no write/read permission #237

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

PrimozGodec
Copy link
Collaborator

Issue

Same issue than here: biolab/orange-canvas-core#288

Description of changes

When there is no read or write permission, ignore the cache.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #237 (75db417) into master (02356b8) will increase coverage by 0.23%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #237      +/-   ##
==========================================
+ Coverage   72.73%   72.97%   +0.23%     
==========================================
  Files          18       18              
  Lines        2850     2875      +25     
  Branches      399      402       +3     
==========================================
+ Hits         2073     2098      +25     
  Misses        664      664              
  Partials      113      113              

@lanzagar lanzagar merged commit 9d56094 into biolab:master Oct 30, 2023
14 checks passed
@PrimozGodec PrimozGodec deleted the fix-cachecontrol branch October 30, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants