Make ControlServices comply with autostart server settings #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- do not start the service(s) if their respective autostart setting is set to false, a regression probably existing since Dicoogle 3.0.0 - remove unused variable `webServicesRunning` in ControlServices - remove use of raw types in startStorage() - remove outdated TODO note - refactor ControlServices#startStorage() to return and raise exception - adjust ServicesServlet according to changes to ControlServices and to be more informative
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
webServicesRunninginControlServicesstartStorage()ControlServices#startStorage()to return whether the service started (true) or was already running (false) and raise an exception on errorServicesServletaccording to changes toControlServices, and for the output to be more precise and informative