-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webapp maintenance (2024) #690
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Webapp continues to work as intended, with these new changes.
Looks good for me!
We've been testing the webapp with these changes for a while. For the most part things seem to be in good order. |
This will be on-hold until this situation is solved. |
- react-router 4 - css-loader 7 - sass-loader 14 - style-loader 4 - webpack-dev-server 5 - npm update
- css-loader 7 - sass-loader 14 - style-loader 4 - webpack-dev-server 5 - npm update
- provide react-router-dom instead of react-router via external require
No longer used
e725818
to
f011b67
Compare
I have decided to revert the upgrade of react-router so that it can be worked on separately. When doing so, we must not forget to test for routing capabilities within a web UI plugin. I'm thinking that at the same time we should try a better React integration again, one which does not force us to create multiple rendering contexts. In other words, this one is ready for a final review. |
f011b67
to
dda4b99
Compare
- keep using version 3 while we do not have a way for routing to work in web UI plugins
dda4b99
to
17b5c3c
Compare
- remove eslint-webpack-plugin
Summary
react-router 4npm update
so that other dependencies are refreshednpm update
on webcore