Create a common interface for weight conversion #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thodkatz
force-pushed
the
weight-converters
branch
from
c032646
to
3128fe4
Compare
- Instead of having one module per conversion, use one module, and individual classes will handle the logic of the conversion - Create an abstract class to have a common interface among conversions
thodkatz
force-pushed
the
weight-converters
branch
from
3128fe4
to
a37b568
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have attempted to resolve the #383.
Initially I did minor fixes to the weight convresions while adding tests. Each weight conversion method returns the corresponding
WeightDescr(fbbfc57).Then, to enforce a common approach for different weight conversion formats, we could use an absrtact class to define the interface (a37b568). Basically I moved the implementation of each function per module to their respective class, non functional change.
Potentially we could have a factory class for all the converters as well.