-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added default moltype for infernal #23
Conversation
Be sure to view this one with whitespace hidden when reviewing (this link will show you the diff with whitespace hidden). |
@josenavas, can you review this one? Need it for a QIIME PR. |
Just out of curiosity, why DNA as default instead of RNA when the tool is built with RNA in mind? |
The code looks good. As we now there is no way of testing this before merging, so we can merge, run it through QIIME and check that it didn't broke anything. @gregcaporaso once you provide an answer to @squirrelo I'll merge this |
@squirrelo, it's because the only place that we're using brokit is QIIME, where we're passing DNA sequences in. (This whole package is kind of a necessary evil to remove the PyCogent dependency from QIIME.) |
Note that I tested locally and the change works. |
Fair enough. This is just something that's going to come up when brokit is On Tue, May 13, 2014 at 10:43 PM, Greg Caporaso [email protected]:
|
Thanks @gregcaporaso merging. @squirrelo this repo should be used only on QIIME until we decide which app controllers do we actually want to include in skbio. Then, they'll be recoded.... |
added default moltype for infernal
Thanks! |
this should have been part of #19