Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix portability issues with sed and sort in MacOS & Linux #263

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Fix portability issues with sed and sort in MacOS & Linux #263

merged 1 commit into from
Apr 26, 2024

Conversation

borland667
Copy link
Contributor

@borland667 borland667 commented Apr 25, 2024 •
edited
Loading

What?

  • Detect Operating system and use GNU sed & sort commands.

Why?

  • Current bump version commands in Makefile only works in MacOS.

Before release

Review the checklist here

@borland667 borland667 requested a review from juanmatias April 25, 2024 13:51
@borland667 borland667 self-assigned this Apr 25, 2024
@coveralls
Copy link
Collaborator

coveralls commented Apr 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8834935454

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 69.031%
Totals Coverage Status
Change from base Build 8832454108: 0.0%
Covered Lines: 2018
Relevant Lines: 2812
💛 - Coveralls

@borland667 borland667 force-pushed the fix-sed-macos branch 10 times, most recently from 0d2100e to 730a5f1 Compare April 25, 2024 14:59
@borland667 borland667 changed the title Fix issue with sed in macos & linux Fix portability issues with sed and sort in MacOS & Linux Apr 25, 2024
angelofenoglio
angelofenoglio approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@angelofenoglio angelofenoglio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting

@borland667 borland667 merged commit 79bc496 into master Apr 26, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelofenoglio angelofenoglio angelofenoglio approved these changes

@juanmatias juanmatias Awaiting requested review from juanmatias

Assignees

@borland667 borland667

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@borland667 @coveralls @angelofenoglio