Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[159] Improve apply arguments parsing logic #260

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Conversation

borland667
Copy link
Contributor

@borland667 borland667 commented Apr 11, 2024

What?

  • Current logic for parsing arguments after apply does not work as expected.
  • leverage tf apply -target kubernetes_manifest.irfq -> fails
  • leverage tf apply -target kubernetes_manifest.irfq -> works

Why?

  • both options for specifying parameters with space or equal should work.

References

Before release

Review the checklist here

@borland667 borland667 requested a review from Franr April 11, 2024 18:34
@coveralls
Copy link
Collaborator

coveralls commented Apr 11, 2024

Pull Request Test Coverage Report for Build 8739936615

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 55 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.3%) to 59.148%

Files with Coverage Reduction New Missed Lines %
modules/terraform.py 55 38.28%
Totals Coverage Status
Change from base Build 8739620586: 0.3%
Covered Lines: 1261
Relevant Lines: 2041

💛 - Coveralls

@borland667 borland667 force-pushed the 159-fix-apply-issue branch 3 times, most recently from d4e1ceb to 915a07e Compare April 11, 2024 19:23
@borland667 borland667 requested a review from juanmatias April 11, 2024 19:28
@borland667 borland667 force-pushed the 159-fix-apply-issue branch 2 times, most recently from 78251f3 to 559be2b Compare April 11, 2024 19:58
@borland667 borland667 force-pushed the 159-fix-apply-issue branch 4 times, most recently from 285d02d to d5666b4 Compare April 11, 2024 20:32
@borland667 borland667 added bug Something isn't working patch labels Apr 12, 2024
@borland667 borland667 self-assigned this Apr 12, 2024
@borland667 borland667 linked an issue Apr 17, 2024 that may be closed by this pull request
@borland667 borland667 force-pushed the 159-fix-apply-issue branch from 7299295 to 3363738 Compare April 18, 2024 14:40
@borland667 borland667 force-pushed the 159-fix-apply-issue branch from 3363738 to abc6f65 Compare April 18, 2024 14:40
@borland667 borland667 merged commit a8f78bd into master Apr 18, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug | failure when running apply with parameters with space
4 participants