Skip to content

Commit

Permalink
chore: deprecate python 3.8 (#289)
Browse files Browse the repository at this point in the history
* Deprecate python 3.8

* Update lock file

* Drop python 3.12 from tests

* Drop python 3.12

* Bump yaenv version
  • Loading branch information
angelofenoglio authored Nov 4, 2024
1 parent 2992536 commit 4f77c9d
Show file tree
Hide file tree
Showing 7 changed files with 658 additions and 555 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/release-pypi-build-push-package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:

- uses: actions/setup-python@v2
with:
python-version: '3.8'
python-version: '3.9'

- name: Install Poetry
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-pypi-build-push-test-package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:

- uses: actions/setup-python@v2
with:
python-version: '3.8'
python-version: '3.9'

- name: Install Poetry
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/tests-integration.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ jobs:
strategy:
max-parallel: 1
matrix:
python-version: ['3.8.14', '3.9.15', '3.10.8', '3.11.8', '3.12.5']
toolbox-image-tag: ['1.3.5-0.1.15', '1.5.0-0.1.15', '1.6.0-0.1.15']
python-version: ['3.9.15', '3.10.8', '3.11.8']
toolbox-image-tag: ['1.3.5-0.2.0', '1.5.0-0.2.0', '1.6.0-0.2.0']
steps:
- name: Checkout base branch
uses: actions/checkout@v3
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/tests-unit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: [ '3.8', '3.9', '3.10', '3.11' , '3.12']
python-version: ['3.9', '3.10', '3.11']
steps:
- uses: actions/checkout@v3

Expand Down Expand Up @@ -38,7 +38,7 @@ jobs:
shell: bash

- name: Report Coveralls
if: matrix.python-version == '3.8' # Run this for the first python version only!
if: matrix.python-version == '3.9' # Run this for the first python version only!
uses: coverallsapp/github-action@v2
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
11 changes: 4 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ PROJECT=bb
MFA_ENABLED=false
# Terraform
TERRAFORM_IMAGE_TAG=1.2.7-0.1.0
TERRAFORM_IMAGE_TAG=1.5.0-0.2.0
```

So, if you have created a project with version <1.8.0 and want to use it with version >=1.8.0 you should:
Expand All @@ -66,7 +66,6 @@ For the second item you can check the version [here](https://hub.docker.com/r/bi

Leverage CLI explicitly supports the following Python versions:

- Python 3.8.x
- Python 3.9.x
- Python 3.10.x
- Python 3.11.x
Expand All @@ -81,7 +80,7 @@ reinforces our commitment to maintaining a reliable and stable toolset.

### Installing multiple python versions with pyenv

If you need to install one of the supported Python versions (3.8, 3.9, 3.10 or 3.11) and would like to manage multiple
If you need to install one of the supported Python versions and would like to manage multiple
Python environments, `pyenv` is a highly recommended tool. Here’s how you can use `pyenv` to install and manage Python
versions:

Expand All @@ -107,7 +106,6 @@ exec "$SHELL"
Once pyenv is installed, you can install any supported Python version by following these steps:

```bash
pyenv install 3.8.10
pyenv install 3.9.7
pyenv install 3.10.1
pyenv install 3.11.8
Expand Down Expand Up @@ -135,8 +133,7 @@ ensuring that all Python operations within this directory use this isolated envi

## Setting up development environment

Before you begin, ensure you are running Python 3.8, 3.9, or 3.10 as these are the only versions Leverage CLI supports
and tests against.
Before you begin, ensure you are running one of the supported Python versions.

We now use Poetry for dependency management. Setup your development environment as follows:

Expand Down Expand Up @@ -230,7 +227,7 @@ respectively.
* There is an Action called "Test Build Package and Push".
* This Action can be called manually on any branch specifying the version to release to test.
* The version is a Release Candidate following the Semver: e.g. if the next release is 1.2.3, the test version
should be 1.2.3-rc.1
should be 1.2.3rc.1
* The package will be published to [PyPi](https://pypi.org/project/leverage/).

## Contributors/Contributing
Expand Down
Loading

0 comments on commit 4f77c9d

Please sign in to comment.