Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest version of tfstate module #42

Merged
merged 3 commits into from
May 7, 2024
Merged

Conversation

martingaleano
Copy link
Contributor

What?

  • Use latest version of tfstate backend module (v1.0.28)
  • Add necessary parameters

References

exequielrafaela
exequielrafaela previously approved these changes May 2, 2024
@diego-ojeda-binbash
Copy link
Contributor

@martingaleano Would you remind me why you removed the default billing mode?

@martingaleano
Copy link
Contributor Author

@martingaleano Would you remind me why you removed the default billing mode?

This new version of tfstate module adds the billing_mode handling:

image

You can compare both version here: binbashar/terraform-aws-tfstate-backend@v1.0.23...v1.0.28

In v1.0.23 we were using read_capacity and write_capacity with 5 as value. At first I tried to keep using those values so the transition from 1.0.23 to 1.0.28 would be more transparent . That's why I used billing_mode with PROVISIONED value at first.

The default value now is PAY_PER_REQUEST. At the end I though this would be a better choice because we are charged on demand.

Now I took a look at DynamoBD pricing and realized that PROVISIONED mode has a free tier that can help us -> https://aws.amazon.com/dynamodb/pricing/provisioned/

I think we were using this free tier during this time and it's better if we continue this way.

What do you think?

@diego-ojeda-binbash
Copy link
Contributor

@martingaleano Would you remind me why you removed the default billing mode?

This new version of tfstate module adds the billing_mode handling:

image

You can compare both version here: binbashar/[email protected]

In v1.0.23 we were using read_capacity and write_capacity with 5 as value. At first I tried to keep using those values so the transition from 1.0.23 to 1.0.28 would be more transparent . That's why I used billing_mode with PROVISIONED value at first.

The default value now is PAY_PER_REQUEST. At the end I though this would be a better choice because we are charged on demand.

Now I took a look at DynamoBD pricing and realized that PROVISIONED mode has a free tier that can help us -> https://aws.amazon.com/dynamodb/pricing/provisioned/

I think we were using this free tier during this time and it's better if we continue this way.

What do you think?

Sounds good.

@martingaleano
Copy link
Contributor Author

@diego-ojeda-binbash I've just added billing_mode = "PROVISIONED" as we discussed in this thread

@martingaleano martingaleano merged commit 2ab3044 into master May 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants