Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement | Create symlinked common-variables.tf file (ISSUE-31) #40

Merged
merged 8 commits into from
Apr 5, 2024
Merged

Enhancement | Create symlinked common-variables.tf file (ISSUE-31) #40

merged 8 commits into from
Apr 5, 2024

Conversation

rodriguez-matias
Copy link
Contributor

What?

  • Add /config/common-variables.tf via symlink in each layer.

Why?

  • Centralized variables in a common file and add local variables in the variables.tf files per layer in order to declare specific layer vars.
  • Be sync with the leverage-ref-arch

Reference

It closes #31

@rodriguez-matias rodriguez-matias self-assigned this Mar 25, 2024
@rodriguez-matias rodriguez-matias requested a review from a team as a code owner March 25, 2024 12:59
diego-ojeda-binbash
diego-ojeda-binbash previously approved these changes Mar 25, 2024
View reviewed changes
template/config/common-variables.tf Outdated Show resolved Hide resolved
template/config/common-variables.tf Outdated Show resolved Hide resolved
@rodriguez-matias rodriguez-matias mentioned this pull request Apr 1, 2024
Open
@rodriguez-matias rodriguez-matias merged commit b21c7ef into master Apr 5, 2024
2 checks passed
@rodriguez-matias rodriguez-matias deleted the ISSUE-23/feat/symlink-common-variables branch April 5, 2024 15:22
@exequielrafaela exequielrafaela added enhancement New feature or request patch labels May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diego-ojeda-binbash diego-ojeda-binbash diego-ojeda-binbash approved these changes

@angelofenoglio angelofenoglio Awaiting requested review from angelofenoglio

Assignees

@rodriguez-matias rodriguez-matias

Labels
enhancement New feature or request patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rodriguez-matias @angelofenoglio @diego-ojeda-binbash @exequielrafaela