Skip to content

Commit

Permalink
CONTRIBUTING.md: follow up GO* variable cleanup (thanos-io#4159)
Browse files Browse the repository at this point in the history
Bonus, remove reference to GOROOT, which does not need to be referenced:
https://dave.cheney.net/2013/06/14/you-dont-need-to-set-goroot-really.

Signed-off-by: Lucas Servén Marín <[email protected]>
  • Loading branch information
squat authored May 4, 2021
1 parent 61edbae commit 4891dc8
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -92,14 +92,14 @@ component of the Thanos distributed system. We recommend:

* Find any directory in your system your want Thanos repo in. e.g `~/Repos` -
* `cd ~/Repos`
* Make sure you have GOBIN, GOPATH and GOPROXY (useful) set to PATH. For example -
* Make sure that the GOBIN, GOPATH and GOPROXY (useful) environment variables are set and that GOBIN is included in your PATH. For example -
```
export GOBIN="~/Repos/thanos/.bin" # It's nice to have local tooling installed and stored locally.
export GOPATH="~/Repos/thanosgopath" # Use if you want to have an isolated directory for deps, otherwise, the dir where you have installed golang will be used.
export GOPATH="~/Repos/thanosgopath" # Use if you want to have an isolated directory for deps, otherwise, the directory where you have installed golang will be used.
export GOPROXY="https://proxy.golang.org"
export PATH="$GOBIN:$GOROOT/bin:$PATH"
export PATH="$GOBIN:$PATH"
```
* Consider adding the environment variables to your host machine (e.g `/.bashrc` or [`.envrc`](https://direnv.net/)) file so that those environment variables are persisted across sessions.
Expand Down

0 comments on commit 4891dc8

Please sign in to comment.