Configurable user model & new aggregate value #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding SECOND as aggregate option, and adding User Model configuration variable.
1. Making user relation configurable. 2. Adding SECOND aggregate to set microsecond to 0 MSSQL isn't getting microseconds as 0. - Value before changes: 2024-04-29 00:00:00.950 New code now set microsecond to 0. - Value after changes: 2024-04-30 00:00:00.000 Note: Migrate haven't been modified. Date column type is datetime.
|
In our side, now the counter updates as expected. |
Remove part from separate PR
Revert relationship changes
|
Hello @bilfeldt Thank you for accepting some changes. Is there anything wrong with the relationship changes? route-statistics.php & RouteStatistic.php updates were removed. Could those changes be added to make user model configurable? At least similar to logger... |
|
@CyberEkklesiaOwner sorry about the confusion. Can you please make a separate PR for the user model config, then I will happily merge that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Making user model configurable and add SECOND aggregate to set microsecond to 0.
Does this close any currently open issues?
No. But the configurable model is needed to make code compatible with LdapRecord. LdapRecord, when using database configuration, the user relation is from auth.providers.users.database.model and not from auth.providers.users.model. Therefore, both packages won't work together. As of now, a custom model is required.
The aggregate is needed for MSSQL. Currently, once date is inserted, the datetime value still accepting time other than 0.
Before aggregate: 2024-04-29 00:00:00.950
After aggregate: 2024-04-30 00:00:00.000