re-fix zip traversal vuln, path discrepancy

/data/data/foo vs /data/user/0/foo, as suggested by @jcperuffo in MobileChromeApps#92 (comment)
bikubi · May 19, 2022 · a3855df · a3855df
1 parent 1fe648b
commit a3855df
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/android/Zip.java b/src/android/Zip.java
@@ -127,7 +127,8 @@ private void unzipSync(CordovaArgs args, CallbackContext callbackContext) {
                 } else {
                     File file = new File(outputDirectory + compressedName);
                     String canonicalPath = file.getCanonicalPath();
-                    if (!canonicalPath.startsWith(outputDirectory)) {
+                    String absolutePath = file.getAbsolutePath();
+                    if (!canonicalPath.startsWith(outputDirectory) && !absolutePath.startsWith(outputDirectory)) {
                         String errorMessage = "Zip traversal security error";
                         callbackContext.error(errorMessage);
                         Log.e(LOG_TAG, errorMessage);