Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(swap): apply swap delay in swap function instead of handleAjaxResponse #2845

Open
wants to merge 12 commits into
base: dev
Choose a base branch
from

Conversation

boonedox
Copy link

@boonedox boonedox commented Aug 23, 2024

Description

moved application of swap delay to swap function so that the JS api can also use the swap delay

Corresponding issue:

Testing

manually tested in my local environment, both with the JS api and with normal hx requests

Checklist

  • I have read the contribution guidelines
  • I have targeted this PR against the correct branch (master for website changes, dev for
    source changes)
  • This is either a bugfix, a documentation update, or a new feature that has been explicitly
    approved via an issue
  • I ran the test suite locally (npm run test) and verified that it succeeded

@Telroshan Telroshan added enhancement New feature or request needs test PR needs a test needs rebase/retarget labels Aug 25, 2024
@Telroshan
Copy link
Collaborator

Hey,

  • You'll want to rebase against dev (not merge) to drop unnecessary commits that currently pollute your PR's diff
  • Could you add test cases for this?
    Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs rebase/retarget needs test PR needs a test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants