Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HX-Redirect causing indicators to clear before redirect #2779

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

webdevcody
Copy link

not sure if this would break stuff, but I was seeing issues with the indicators clearing before the redirect finished. See video for issue.

z-redirect.mp4

@Telroshan Telroshan added the enhancement New feature or request label Aug 1, 2024
@Telroshan
Copy link
Collaborator

Hey, seems you'll want to run npm format to properly lint your code.

Other than that, I'm wondering what this pageshow event handling is about, is it necessary in this case? What issue does it solve?

@webdevcody
Copy link
Author

webdevcody commented Aug 1, 2024

@Telroshan Here is the issue without the pageshow. Basically the browser is going to cache the state of the previous page, so since we do not ever re-enable the button or hide the indicator, it'll show when the user clicks back.

pageshow.mp4

@1cg 1cg mentioned this pull request Aug 1, 2024
@jadamita
Copy link

jadamita commented Aug 2, 2024

@Telroshan Here is the issue without the pageshow. Basically the browser is going to cache the state of the previous page, so since we do not ever re-enable the button or hide the indicator, it'll show when the user clicks back.

pageshow.mp4

off topic, but what software was used for that recording? it's buttery smooth.

@JonathanFajobi
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants