Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translations support to start and publish commands #96

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

darrenbelding
Copy link

What? Why?

This PR adds translation support to allow for the publishing of translatable widgets and report invalid schema feedback in a development environment. This issue was reported here: #90

Testing / Proof

A test environment is available on the test-translation-support branch of the Space48 fork containing 2 examples of widgets: with-translations and without-translations.

The start command has been tested under the following conditions:

  • With a widget containing a schema_translations.json
  • With a widget that does not contain a schema_translations.json
  • With an invalid schema_translations.json and then correcting the invalid schema (for the purposes of dev reload)

The publish command has been tested under the following conditions:

  • With a widget containing a schema_translations.json
  • With a widget that does not contain a schema_translations.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant