Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Management API][Orders] DEVDOCS-6190 Update orders shipping_cost_X_tax descriptions #741

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

BC-SEven
Copy link
Contributor

@BC-SEven BC-SEven commented Jan 8, 2025

DEVDOCS-6190

What changed?

  • Updated description for shipping_cost_inc_tax & shipping_cost_ex_tax in prep for stricter validation

Release notes draft

Anything else?

ping @bigcommerce/team-orders

Copy link
Contributor

@donald-nguyen-bc donald-nguyen-bc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@TomA-R TomA-R changed the title [Managmenet API][Orders] DEVDOCS-6190 Update orders shipping_cost_X_tax descriptions [Management API][Orders] DEVDOCS-6190 Update orders shipping_cost_X_tax descriptions Jan 9, 2025
@BC-SEven BC-SEven merged commit 4a7c05f into main Jan 9, 2025
3 checks passed
@BC-SEven BC-SEven deleted the DEVDOCS-6190 branch January 9, 2025 23:37
@bc-traciporter
Copy link
Collaborator

Hi @donald-nguyen-bc and @BC-SEven Here is what I have for the release notes. Please let me know if this is okay or if I need to explain more.

API

  • Updated the description for shipping_cost_inc_tax and shipping_cost_ex_tax fields in v2 Orders API in preparation for stricter validation.

@BC-SEven
Copy link
Contributor Author

Hi @donald-nguyen-bc and @BC-SEven Here is what I have for the release notes. Please let me know if this is okay or if I need to explain more.

API

  • Updated the description for shipping_cost_inc_tax and shipping_cost_ex_tax fields in v2 Orders API in preparation for stricter validation.

Hmmm probably something like this is more accurate:

API

  • If a shipping cost is supplied for either the POST or PUT /v2/orders request payloads, both shipping_cost_inc_tax and shipping_cost_ex_tax must now be provided to prevent negative shipping cost tax values.

What do we think @bc-jwk? Is this okay for our release notes?

@bc-traciporter
Copy link
Collaborator

bc-traciporter commented Jan 16, 2025

Thank you @BC-SEven That helps, I will use the following:
API

  • When submitting a shipping cost for the POST and PUT v2 orders request, you must include both shipping_cost_inc_tax and shipping_cost_ex_tax in the payload. This change ensures accurate calculations and prevents negative shipping cost tax values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants