Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEVDOCS-6056 [new]: Price Lists / MSF International Enhancements, add tax inclusive price lists #550
base: main
Are you sure you want to change the base?
DEVDOCS-6056 [new]: Price Lists / MSF International Enhancements, add tax inclusive price lists #550
Changes from 5 commits
9164c5d
39c8a65
3796b98
e8d9e3d
0a3af18
c358587
aa91197
18c8ff9
6073633
fe6c02b
d75ad33
e37cf72
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this sentence is accurate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to change the wordings here -
modifier rules, gift wrapping features, and fixed shipping prices into a price list. These inherit global settings
because we apply the prices from modifier rules, gift wrapping features, and fixed shipping on top of the prices in price list true, but it doesnt inherit global settings, its inherits the tax inc/ex setting from the price list that will apply for that instant of channel and customer, even though its not part of the price list yet. I think giving this clarity might help merchants less confused how the global setting prices will apply with price list inc/ex.cc @megdesko
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bc-vinbase is correct. These will inherit the setting from the price list and will not be treated as the global setting.
Maybe
These inherit global settings and always apply on top of the price list.
should be changed toThese prices will be applied as-is with with the prices entered with tax setting for the current shopper applied
or similar?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we need an example here like
Your store has (in USD)
$1.99 fixed shipping
+$3 for gift wrapping
Those are entered global (ex tax)
You add an inc tax price list that has prices in Australian dollars- for simplicity, let's say it's 2 AUD to 1 USD
So maybe $55.97 AUD for the price of the product
We will currency convert the $5 modifier rule to $10 AUD
$3.98 for fixed shipping
$6 for gift wrapping
These prices will inherit the price list setting, so they'll be added as is, so the cart total for that item with the modifier rule selected will be
55.97 + 5 + 6 + 3.98 = $70.95 AUD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@megdesko Thanks, clarified it and added an example. I assume you meant to use the $10 modifier rule in your final calculation (to total $75.95)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given MSF feature is turned on :) just clarifying it for myself too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They can still do it via API, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also add something about going into Settings > Tax > Store Tax Settings and turning on
Keep prices as entered
forWhen calculating the taxes on sales made outside the pricing tax zone
especially for folks on default ex tax stores
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see this below now :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only true if they turn on the setting I mentioned above- otherwise tax unwinding will kick in and sadness will ensue.
I think this is being changed to make it the default for ex tax stores, but depending on when someone sees this doc that may not be completed/ totally rolled out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I added a sentence about the setting, but I believe my doc could be further clarified.
I rethought about the feature, and my current understanding is:
When calculating the taxes on sales made outside the pricing tax zone
setting is only important when you want tax-inclusive prices (the setting doesn't matter if you want tax-exclusive prices).When calculating the taxes on sales made outside the pricing tax zone
setting for the price list. So I'm guessing this pretty-pricing setting would inherit the global value (assuming the global store is also set to tax-inclusive).^ @benpratt77 can you comment on the default value?