Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update babel dependency in stencil react foundation doc #491

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Update babel dependency in stencil react foundation doc #491

merged 2 commits into from
Sep 5, 2024

Conversation

becomevocal
Copy link
Contributor

What changed?

  • Updated the Babel plugin dependency that's recommended in the React foundation doc for Stencil, since it has moved into a new package since the doc was original created

Release notes draft

  • Stencil React foundation doc has been updated to work with the latest Babel plugin packages. Now the guidance works for React 18.

@becomevocal becomevocal requested review from a team and bc-tgomez and removed request for a team September 3, 2024 13:35
bc-traciporter
bc-traciporter approved these changes Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@bc-traciporter bc-traciporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@bc-traciporter bc-traciporter merged commit 0b1a704 into main Sep 5, 2024
3 checks passed
@bc-traciporter bc-traciporter deleted the stencil-react-babel-update branch September 5, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bc-traciporter bc-traciporter bc-traciporter approved these changes

@bc-tgomez bc-tgomez Awaiting requested review from bc-tgomez bc-tgomez was automatically assigned from bigcommerce/dev-docs-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@becomevocal @bc-traciporter