-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tax): TAX-1995 Add specs for new TaxZone check endpoint #12
Conversation
14432ab
to
d6a8d27
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you sir
Work continued in PR 54 |
content: | ||
application/json: | ||
schema: | ||
type: array |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing around, it seems like the request is an object (instead of an array), so I fixed the doc in PR 54
type: object | ||
properties: | ||
data: | ||
type: array |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same thing here, my testing showed data is an object, not an array, so fixed in PR 54
# [DEVDOCS-5714] Add documentation in api-specs repo for our new ZoneCheck endpoint https://bigcommercecloud.atlassian.net/browse/TAX-1995 ## What changed? * Added new spec file for the `tax/zonecheck` endpoint ## Anything else? bigcommerce/api-proxy-java#2659 (comment) Specs match the response: <img width="1309" alt="Screenshot 2023-12-29 at 10 28 52 am" src="https://github.com/bigcommerce/docs/assets/40374950/c84912fd-bb52-45af-962c-30c2cdb49b82"> ping @bigcommerce/team-shipping [DEVDOCS-5714]: https://bigcommercecloud.atlassian.net/browse/DEVDOCS-5714?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
DEVDOCS-5714
Add documentation in api-specs repo for our new ZoneCheck endpoint
https://bigcommercecloud.atlassian.net/browse/TAX-1995
What changed?
tax/zonecheck
endpointAnything else?
https://github.com/bigcommerce/api-proxy-java/pull/2659#issuecomment-1859527805
Specs match the response:
ping @bigcommerce/team-shipping