Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
B2B-1354: [update] fix s2s endpoints review issues (#598)
<!-- Ticket number or summary of work --> # [B2B-1354](https://bigcommercecloud.atlassian.net/browse/B2B-1354) ## What changed? <!-- Provide a bulleted list in the present tense --> ### Fix some issues Fix s2s endpoints issues in [google doc](https://docs.google.com/document/d/1maGQinFAxBQH8b3h0EGwzUZi9ikpf-mAgTWgVLqGo4I/edit?usp=sharing) * company a. Bulk Create Companies (request body has these additional read only fields (bcGroupName and companyStatus) **Create a new model for bulk company create (copy from orrigin), and remove 2 read only fields** * User a. Get a User (companyRoleId and companyRoleName missing from response body) **Add companyRoleName and companyRoleId in user response model** b. Get a User (meta is missing from the 404 error response) **Fix 404 response** c. Get a User (Should we document a 500 error response?) **Remove 500 response** d. Update a User (companyRoleId and companyRoleName are not in response body) **Add companyRoleName and companyRoleId in user response model** e. Delete a User (meta is missing from the 404 error response) **Fix 404 response** f. Delete a User (Should we document a 500 error response?) **Remove 500 response** g. Get Users (companyRoleId and companyRoleName missing from response body) **Add companyRoleName and companyRoleId in user response model** i. Bulk Create Company User (meta is missing from the 404 error response) **Fix 404 response** j. Get a User by Customer ID (companyRoleId and companyRoleName missing from response body) **Add companyRoleName and companyRoleId in user response model** k. Get a User by Customer ID (meta is missing from the 404 error response) **Fix 404 response** * Sales Staff a. Get a Sales Staff (assignedAt field is missing from the response body > assignedCompanies) **Add assignAt** * invoice payment a. Update a Offline Payment (422 error response is this correct? Data > currency) **Fix 422 response** ### Remove task section The task section has been removed in PR [535](#535), but re-created in PR [562](#562). May be conflicts between PR. As this section has already been removed in the original Stoplight, it should be removed again. ## Release notes draft <!-- Provide an entry for the release notes using simple, conversational language. Don't be too technical. Explain how the change will benefit the merchant and link to the feature. Examples: * The newly-released [X feature] is now available to use. Now, you’ll be able to [perform Y action]. * We're happy to announce [X feature], which can help you [perform Y action]. * [X feature] helps you to create [Y response] using the [Z query parameter]. Now, you can deliver [ex, localized shopping experiences for your customers]. * Fixed a bug in the [X endpoint]. Now the [Y field] will appear when you click [Z option]. --> n/a [B2B-1354]: https://bigcommercecloud.atlassian.net/browse/B2B-1354?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --------- Co-authored-by: Traci Porter <[email protected]>
- Loading branch information