This repository has been archived by the owner on Jan 15, 2024. It is now read-only.
(no ticket): [update] Marketing, coupon name must be unique #1537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creating a second coupon with the same name as an existing coupon will cause the API to return `409 Conflict`. Hence, the name parameter must be unique.
|
Thanks for the feedback, @gslandtreter! We'll merge this after getting approval from @bc-traciporter. 🙇 |
bc-tgomez
added
ready for review
bc-traciporter
previously approved these changes
Dec 12, 2023
Co-authored-by: Traci Porter <[email protected]>
slsriehl
approved these changes
Dec 15, 2023
There was a problem hiding this comment.
re-approving after accepting @bc-traciporter 's suggestion.
slsriehl
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a second coupon with the same name as an existing coupon will cause the API to return
409 Conflict. Hence, the name parameter must be unique.