Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

DEVDOCS-5483 [new]: Settings API, add channel_id query parameter to locale settings #1487

Merged
merged 2 commits into from
Oct 6, 2023

Conversation

bc-andreadao
Copy link
Contributor

@bc-andreadao bc-andreadao commented Oct 5, 2023

DEVDOCS-5483

What changed?

  • Add channel_id as a query parameter to GET and PUT locale settings endpoint
  • Add description to explain how to remove channel override

Copy link

@andrii-lenets andrii-lenets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bc-andreadao
Copy link
Contributor Author

Thanks @andrii-lenets

Copy link
Contributor

@bc-traciporter bc-traciporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bc-andreadao bc-andreadao merged commit 4852133 into main Oct 6, 2023
3 checks passed
@bc-andreadao bc-andreadao deleted the DEVDOCS-5483-channel-locale-settings branch October 6, 2023 21:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants