Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

DEVDOCS-5425 [new]: Tax Settings API, add tax zone based price display for storefront #1456

Merged
merged 8 commits into from
Oct 25, 2023

Conversation

bc-msung
Copy link
Contributor

@bc-msung bc-msung commented Sep 6, 2023

[DEVDOCS-5425]

Tax Zone Based Price Display For Storefront

What changed?

As part of Tax Zone Based Price Display for Storefront, three new tax settings are being introduced to the v3 endpoint.
should_use_geolocation_to_determine_guest_shopper_tax_zone - enabling this features will allow the merchants to display the tax estimation based on the user's geolocation.
'guest_shopper_tax_zone_id- default tax zone id for guest shoppers entering the storefrontstore_tax_zone_id` - default tax zone id for store

Anything else?

Geolocation PR
https://github.com/bigcommerce/bigcommerce/pull/53689
https://github.com/bigcommerce/bigcommerce/pull/53561

Default Tax Zone ID
https://github.com/bigcommerce/bigcommerce/pull/54330
https://github.com/bigcommerce/bigcommerce/pull/54157

ping @bigcommerce/team-tax @bigcommerce/dev-docs @bc-andreadao

@bc-msung bc-msung marked this pull request as ready for review September 6, 2023 02:31
reference/tax_settings.v3.yml Outdated Show resolved Hide resolved
reference/tax_settings.v3.yml Outdated Show resolved Hide resolved
@bc-msung bc-msung force-pushed the TAX-1867 branch 3 times, most recently from 1aa802d to f12160f Compare September 7, 2023 01:42
@theromulans
Copy link
Contributor

The PR description looks to need updating, by the way - some of the template items haven't been filled in.

@bc-msung bc-msung force-pushed the TAX-1867 branch 2 times, most recently from 07cfdd1 to 74d2822 Compare September 7, 2023 03:16
reference/tax_settings.v3.yml Outdated Show resolved Hide resolved
reference/tax_settings.v3.yml Outdated Show resolved Hide resolved
theromulans
theromulans previously approved these changes Sep 11, 2023
Copy link
Contributor

@theromulans theromulans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you sir

@bc-andreadao
Copy link
Contributor

bc-andreadao commented Sep 29, 2023

@bc-msung I made some suggestions. I believe they are still accurate, but let me know.

(I also removed Tax_Settings_Req because it pretty much duplicates Tax_Settings).

Heads up, I'll make a PR for the Tax Settings doc page shortly

@bc-andreadao bc-andreadao changed the title feat(tax): TAX-1867 Update tax settings documentation for tax zone based price display for storefront DEVDOCS-5425 [new]: Tax Settings API, add tax zone based price display for storefront Oct 5, 2023
Copy link
Collaborator

@bc-tgomez bc-tgomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a comment but other than that this is well done!

Copy link
Contributor

@bc-traciporter bc-traciporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @bc-andreadao

@bc-andreadao bc-andreadao merged commit b6766ab into bigcommerce:main Oct 25, 2023
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants