Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

DEVDOCS-4878: [external] Customers V2, remove required fields #1211

Conversation

kzhang-dsg
Copy link
Contributor

@kzhang-dsg kzhang-dsg commented Mar 10, 2023

DEVDOCS-4878

The update customer API does not have any required fields. It is incorrectly documented in the API spec and on the website.

What changed?

  • Removed the required fields for the update customer API (the customer_Put model)
  • Moved the customer_Put model under the schema definations

Anything else?

N/A

@kzhang-dsg kzhang-dsg requested a review from a team as a code owner March 10, 2023 17:22
@slsriehl slsriehl changed the base branch from main to DEVDOCS-4878 April 10, 2023 04:55
@slsriehl slsriehl assigned slsriehl and bc-tgomez and unassigned slsriehl Apr 10, 2023
Copy link
Collaborator

@bc-tgomez bc-tgomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a few editorial suggestions.

reference/customers.v2.yml Outdated Show resolved Hide resolved
reference/customers.v2.yml Outdated Show resolved Hide resolved
reference/customers.v2.yml Outdated Show resolved Hide resolved
reference/customers.v2.yml Outdated Show resolved Hide resolved
reference/customers.v2.yml Outdated Show resolved Hide resolved
reference/customers.v2.yml Outdated Show resolved Hide resolved
reference/customers.v2.yml Outdated Show resolved Hide resolved
@slsriehl slsriehl force-pushed the hotfix/customer-v2-put-model-required-fields branch from 2941afe to ee60d08 Compare December 21, 2023 19:54
@slsriehl slsriehl force-pushed the hotfix/customer-v2-put-model-required-fields branch from ee60d08 to faa24ea Compare December 21, 2023 19:57
@slsriehl slsriehl changed the base branch from DEVDOCS-4878 to main December 21, 2023 19:57
@slsriehl slsriehl dismissed bc-tgomez’s stale review December 21, 2023 20:06

review criticisms handled

@slsriehl slsriehl changed the title Remove required fields for update customer API DEVDOCS-4878: [external] Customers V2, remove required fields Dec 21, 2023
@slsriehl slsriehl merged commit 945ace1 into bigcommerce:main Dec 21, 2023
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants