This repository has been archived by the owner on Jan 15, 2024. It is now read-only.
PROMO-702: [update] Channels, tighten definitions #1179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @leeBigCommerce. Some changes to the spec files are coming in the next few days. I've marked his PR as draft. In the meantime, if PROMO-702 doesn't have an associated CSS project ticket, please ping #operational-readiness so they can get that and a child DEVDOCS ticket made. |
slsriehl
approved these changes
Dec 15, 2023
slsriehl
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PROMO-702
What changed?
dataandmetafields withinmultiple_channels_without_currencies_respmade requiredidandnamefields withinChannelWithoutCurrenciesmade requiredAnything else?
I found some mistakes here while moving to use auto-generated Type definitions for some promotions view work.
The above values were portrayed as potentially
undefined(or nullable), which I don't believe is a true representation of the API.There are likely to a lot more values that are actually required, but that would need someone more knowledgeable of the Channels domain to look into.