Skip to content

Commit

Permalink
Add Node 12 Support (#7)
Browse files Browse the repository at this point in the history
* refactor: updated to support node 12

* chore: updated travis, appveyor and node engines

* chore: correcting package version bump

* chore(cicd): updating appveyor and circleci configs for release

* chore(cicd): adjusting appveyor filter

* chore(cicd): correcting circle and adjusting appveyor

* chore(cicd): testing circle release

* chore(cicd): testing circle ghr

* chore(cicd): final changes to circleci

* chore(cicd): updated to have node 7 and disable travis

* chore(cicd): testing apveyor test run

* chore(cicd): adding test step for appveyor

* chore(cicd): adjusting appveyor back to original build process

* chore(cicd): running appveyor on master as well

* chore(cicd): update to run circleci on tag

* chore(cicd): correcting circleci yaml

* chore(cicd): adjusting circle to fix release issue

* chore(cicd): filter back in place after testing

* chore(cicd): adding artifact store to circleci
  • Loading branch information
Nabil Cheikh authored Oct 2, 2019
1 parent 1fafc15 commit 4d39efa
Show file tree
Hide file tree
Showing 5 changed files with 2,393 additions and 3 deletions.
26 changes: 26 additions & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,13 @@ jobs:
- build
- release

build-linux-node-12:
docker:
- image: circleci/node:12
steps:
- build
- release

build-darwin-node-6:
macos:
xcode: "9.0.1"
Expand Down Expand Up @@ -147,6 +154,15 @@ jobs:
- build
- release

build-darwin-node-12:
macos:
xcode: "10.0.0"
steps:
- install-node:
version: 12
- build
- release

publish-github-release:
docker:
- image: cibuilds/github:0.13
Expand Down Expand Up @@ -189,6 +205,10 @@ workflows:
filters:
tags:
only: /v\d+\.\d+\.\d+$/
- build-linux-node-12:
filters:
tags:
only: /v\d+\.\d+\.\d+$/
- build-darwin-node-6:
filters:
tags:
Expand All @@ -213,6 +233,10 @@ workflows:
filters:
tags:
only: /v\d+\.\d+\.\d+$/
- build-darwin-node-12:
filters:
tags:
only: /v\d+\.\d+\.\d+$/

- publish-github-release:
requires:
Expand All @@ -222,12 +246,14 @@ workflows:
- build-linux-node-9
- build-linux-node-10
- build-linux-node-11
- build-linux-node-12
- build-darwin-node-6
- build-darwin-node-7
- build-darwin-node-8
- build-darwin-node-9
- build-darwin-node-10
- build-darwin-node-11
- build-darwin-node-12

filters:
branches:
Expand Down
12 changes: 12 additions & 0 deletions appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,18 @@
- nodejs_version: 11
GYP_MSVS_VERSION: 2015
APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2015
- nodejs_version: 12
GYP_MSVS_VERSION: 2015
APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2015
- nodejs_version: 10
GYP_MSVS_VERSION: 2017
APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2017
- nodejs_version: 11
GYP_MSVS_VERSION: 2017
APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2017
- nodejs_version: 12
GYP_MSVS_VERSION: 2017
APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2017

install:
# https://www.appveyor.com/docs/lang/nodejs-iojs/#installing-any-version-of-nodejs-or-iojs
Expand Down Expand Up @@ -120,12 +126,18 @@
- nodejs_version: 11
GYP_MSVS_VERSION: 2015
APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2015
- nodejs_version: 12
GYP_MSVS_VERSION: 2015
APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2015
- nodejs_version: 10
GYP_MSVS_VERSION: 2017
APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2017
- nodejs_version: 11
GYP_MSVS_VERSION: 2017
APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2017
- nodejs_version: 12
GYP_MSVS_VERSION: 2017
APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2017

install:
# https://www.appveyor.com/docs/lang/nodejs-iojs/#installing-any-version-of-nodejs-or-iojs
Expand Down
Loading

0 comments on commit 4d39efa

Please sign in to comment.