feat(plugins): Notification API support for plugins #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It allows the user to send a notification client-side. If, on the other hand, a developer wants to make it so that everyone receives a notification at the same time, they can easily do it with the help of a data-channel.
How to test
I, myself, used the
sample-action-button-dropdownto test it. I already left the necessary code change there to make it easier to test. But, one can simply use this API in whatever plugin they want.More
See demo, below:
demo-notification-plugin.mp4
We can always change the UI, of course, but mind that this PR doesn't aim to change the structure of the notification itself, it simply wants to simply open the possibility for a plugin to send a notification in the current notify structure.
But again, this is arguable, so if you have a suggestion, please comment down below.
Closely related to bigbluebutton/bigbluebutton#21625