Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[104] Adds node and npm versions to package.json and .node-version file #116

Merged
merged 4 commits into from
Nov 25, 2024

Conversation

PaulREnglish
Copy link

Description

Issue #104.

Adds node and npm versions to the engines property in package.json so developers know which versions of node are supported. Also adds a .node-version file so package managers automatically use the recommended version.

I set the recommended node version to 18 as it still has a year left in it's lifecycle. I didn't go with node version 20 as some of our installed dependencies do not support it in their current versions. See screenshot:
image

Change Log

  • sets minimum supported node version to 16 and minimum npm version to 8
  • adds a .node-version file to set the default node version to 18.

Steps to test

  1. cd out of the root directory then cd back into it.
  2. If you are using fnm as your package manager, the node version should automatically switch to version 18.
  3. Delete the node_modules folder.
  4. Run npm i.
  5. The packages should install without issues
  6. Run npm watch:dev and check that the plugin still works.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@PaulREnglish PaulREnglish requested review from g-elwell and a team as code owners October 4, 2024 12:12
@PaulREnglish PaulREnglish changed the title Adds node and npm versions to package.json and .node-version file [104] Adds node and npm versions to package.json and .node-version file Oct 8, 2024
@g-elwell g-elwell changed the base branch from main to develop November 25, 2024 11:50
@g-elwell g-elwell merged commit 7ab2aa8 into develop Nov 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants