Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create es-module bundle #43

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Create es-module bundle #43

wants to merge 3 commits into from

Conversation

timrosskamp
Copy link

@timrosskamp timrosskamp commented Jun 20, 2018

Hi,

I recently used macy.js in a project and I have to say I really like it.

In that project I was using rollup.js to bundle all my scripts together. Rollup.js works best when everything is exported in the new standardised es-module pattern. Otherwise you always get some unnecessary overhead in your bundle.

That's why I created this pull request where I updated the version of rollup, to be able to use the newest configuration options. Then I created a separate bundle called dist/macy.es.js with is then declared in the package.json via the fields module and jsnext:main. That way modern module bundlers like rollup an webpack are able to use this specific bundle instead and can optimise the final bundle better.

This doesn't touch the original dist/macy.js and gives a benefit for every rollup/webpack user. I tested it in my project and everything was working fine.

What do you guys think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant