Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I recently used macy.js in a project and I have to say I really like it.
In that project I was using rollup.js to bundle all my scripts together. Rollup.js works best when everything is exported in the new standardised es-module pattern. Otherwise you always get some unnecessary overhead in your bundle.
That's why I created this pull request where I updated the version of rollup, to be able to use the newest configuration options. Then I created a separate bundle called
dist/macy.es.js
with is then declared in thepackage.json
via the fieldsmodule
andjsnext:main
. That way modern module bundlers like rollup an webpack are able to use this specific bundle instead and can optimise the final bundle better.This doesn't touch the original
dist/macy.js
and gives a benefit for every rollup/webpack user. I tested it in my project and everything was working fine.What do you guys think?