This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
Feature/logo list slider #138
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaymcp
suggested changes
Feb 20, 2019
| }; | ||
|
|
||
| initiateDelete = () => { | ||
| if (confirm(__('Are you sure you want to delete this logo from the slider?'))) { // eslint-disable-line no-restricted-globals, no-alert |
There was a problem hiding this comment.
Missing textdomain from __() call.
|
|
||
| this.setState({ | ||
| selectedSlide: selectedSlide - 1, | ||
| group: (selectedSlide - 1) < this.props.attributes.perSlide ? this.props.attributes.perSlide : group - 1, // eslint-disable-line max-len |
There was a problem hiding this comment.
This would be easier to read as a standard conditional statement, rather than a ternary.
|
|
||
| this.setState({ | ||
| selectedSlide: selectedSlide + 1, | ||
| group: (selectedSlide + 1) === (this.props.attributes.slides.length - this.props.attributes.perSlide) ? this.props.attributes.perSlide : group + 1, // eslint-disable-line max-len |
There was a problem hiding this comment.
This would be easier to read as a standard conditional statement, rather than a ternary.
| checked={ attributes.hasArrows } | ||
| onChange={ this.createUpdateAttribute('hasArrows') } | ||
| /> | ||
| <RangeControl |
There was a problem hiding this comment.
The props within this range control are indented incorrectly.
| onChange={ updateSlide('newTab') } | ||
| /> | ||
| { attributes.slides.length >= 2 && ( | ||
| <p>Change milestone position:</p> |
| <p>Change milestone position:</p> | ||
| )} | ||
| <Button onClick={ this.movePrev } className="is-button is-default is-large" style={ { marginRight: '10px' } } disabled={ selectedSlide === 0 }>Move back</Button> | ||
| <Button onClick={ this.moveNext } className="is-button is-default is-large" disabled={ selectedSlide === attributes.slides.length - 1 }>Move forward</Button> |
There was a problem hiding this comment.
The button text should be translatable.
| </div> | ||
| </div> | ||
| <nav className="logoSlider-nav logoSlider-navActions"> | ||
| <button className="logoSlider-navButton logoSlider-navButtonPrev btn" onClick={ () => this.setState({ selectedSlide: selectedSlide - 1, group: group - 1 }) } disabled={group === attributes.perSlide}>{ __('Pevious Logo', 'benenson') }</button> |
There was a problem hiding this comment.
Missing spaces between curly braces on disabled attribute.
| { currentSlide && ( | ||
| <button className="logoSlider-navButton btn" onClick={ this.addSlide }>{ __('Add Logo', 'benenson') }</button> | ||
| ) } | ||
| <button className="logoSlider-navButton logoSlider-navButtonNext btn" onClick={ () => this.setState({ selectedSlide: selectedSlide + 1, group: group + 1 }) } disabled={group === attributes.slides.length || attributes.slides.length <= attributes.perSlide }>{ __('Next Logo', 'benenson') }</button> |
There was a problem hiding this comment.
Missing space after opening curly brace on disabled attribute.
| background-color: $color-grey-brand; | ||
| border-color: $color-grey-brand; | ||
|
|
||
| &:enter { |
| background-color: #c92c2c; | ||
| color: $color-white; | ||
|
|
||
| &:enter { |
|
@jonmcp This is 4 years stale, is it still needed? |
|
@ampersarnie i have no idea |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes