✨ refactor(pterodactyl-wings): simplify mount paths #2530
Conversation
Simplify the mount paths for the Pterodactyl Wings container by removing the `$AppID` variable and using more generic paths. This makes the configuration more portable and easier to manage. The key changes are: - Simplify the mount paths for tmp, etc, logs, and lib directories - Remove the `$AppID` variable from the mount paths - Use more generic paths like `/etc/pterodactyl` and `/var/log/pterodactyl` This change makes the configuration more flexible and easier to maintain, as the paths no longer depend on a specific application ID.
WalkthroughThe pull request modifies the Changes
Poem
Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
Apps/pterodactyl-wings/docker-compose.yml (2)
Line range hint
39-52: Improved volume mount configuration, but needs migration guidance.The simplified volume mounts using standard paths (
/etc/pterodactyl/,/var/log/pterodactyl/, etc.) align with container best practices and improve portability. However, existing installations using the old paths (/DATA/AppData/$AppID/) will need migration instructions.Consider adding migration documentation to help users:
- Back up data from old paths
- Move data to new locations
- Update permissions if needed
- Verify application functionality after migration
Would you like me to help draft the migration guide?
138-138: Enhance installation instructions with permissions and verification steps.While the new configuration path is correct, the instructions could be more comprehensive.
Consider adding these details to the installation tips:
/etc/pterodactyl/config.yml + + Ensure proper file permissions: + - The config file should be readable by the Wings process (WINGS_UID: 988) + - Recommended permissions: 0644 + + Verify the configuration: + - Check the container logs after restart + - Ensure the Wings service can read the configuration
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
Apps/pterodactyl-wings/docker-compose.yml(1 hunks)
🔇 Additional comments (1)
Apps/pterodactyl-wings/docker-compose.yml (1)
Line range hint
10-10: Verify Pterodactyl Wings image version compatibility.The configuration uses
ghcr.io/pterodactyl/wings:v1.11.13. Let's verify this version.✅ Verification successful
Version v1.11.13 is current and appropriate.
The configured version is the latest release and includes recent bug fixes and security patches from previous versions. No breaking changes or path structure modifications are present that would affect compatibility.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check for newer versions and any breaking changes related to path structure gh api \ -H "Accept: application/vnd.github+json" \ repos/pterodactyl/wings/releases | \ jq -r '.[] | select(.prerelease==false) | {tag_name, body}' | \ grep -A 5 -B 5 "path\|directory\|volume\|mount" # Check for security advisories gh api graphql -f query=' { securityVulnerabilities(first: 5, ecosystem: CONTAINER, package: "ghcr.io/pterodactyl/wings") { nodes { advisory { summary severity publishedAt } vulnerableVersionRange firstPatchedVersion { identifier } } } }'Length of output: 12518
Script:
#!/bin/bash # Verify v1.11.13 exists and get its details gh api \ -H "Accept: application/vnd.github+json" \ repos/pterodactyl/wings/releases/tags/v1.11.13 # Check security advisories with correct ecosystem gh api graphql -f query=' { securityVulnerabilities(first: 5, ecosystem: DOCKER, package: "ghcr.io/pterodactyl/wings") { nodes { advisory { summary severity publishedAt } vulnerableVersionRange firstPatchedVersion { identifier } } } }'Length of output: 8023
Simplify the mount paths for the Pterodactyl Wings container by removing the
$AppIDvariable and using more generic paths. This makes the configuration more portable and easier to manage.The key changes are:
$AppIDvariable from the mount paths/etc/pterodactyland/var/log/pterodactylThis change makes the configuration more flexible and easier to maintain, as the paths no longer depend on a specific application ID.
Summary by CodeRabbit