Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc maint #109

Merged
merged 1 commit into from
Oct 4, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/python_build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest]
python-version: ["3.9", "3.10", "3.11"]
python-version: ["3.10", "3.11", "3.12"]
steps:
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/python_publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v4
with:
python-version: "3.10"
python-version: "3.11"
- name: Install dependencies
run: |
python -m pip install --upgrade pip
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/python_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ jobs:
strategy:
fail-fast: false
matrix:
platform: [ubuntu-20.04, ubuntu-latest, macos-latest, windows-latest]
python-version: ["3.9", "3.10", "3.11"]
platform: [ubuntu-22.04, ubuntu-latest, macos-latest, windows-latest]
python-version: ["3.10", "3.11", "3.12"]

env:
TZ: Europe/Berlin
Expand All @@ -45,7 +45,7 @@ jobs:
python -m pip install -e .

- name: install MNE-Python main
if: "matrix.platform == 'ubuntu-20.04'"
if: "matrix.platform == 'ubuntu-22.04'"
run: |
pip install -U git+https://github.com/mne-tools/mne-python

Expand All @@ -58,7 +58,7 @@ jobs:
mne sys_info

- name: Check formatting
if: ${{ matrix.platform == 'ubuntu-20.04' && matrix.python-version == '3.10' }}
if: ${{ matrix.platform == 'ubuntu-22.04' && matrix.python-version == '3.11' }}
run: |
make pep
pre-commit run --all-files || ( git status --short ; git diff ; exit 1 )
Expand All @@ -72,14 +72,14 @@ jobs:
make build-doc

- name: Upload artifacts
if: ${{ matrix.platform == 'ubuntu-20.04' && matrix.python-version == '3.10' }}
if: ${{ matrix.platform == 'ubuntu-22.04' && matrix.python-version == '3.11' }}
uses: actions/upload-artifact@v3
with:
name: docs-artifact
path: docs/_build/html

- name: Upload coverage report
if: ${{ matrix.platform == 'ubuntu-20.04' && matrix.python-version == '3.10' }}
if: ${{ matrix.platform == 'ubuntu-22.04' && matrix.python-version == '3.11' }}
uses: codecov/codecov-action@v3
with:
files: ./coverage.xml
4 changes: 2 additions & 2 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,11 @@ repos:
hooks:
- id: isort
- repo: https://github.com/psf/black
rev: "23.1.0"
rev: "23.9.1"
hooks:
- id: black
- repo: https://github.com/pycqa/flake8
rev: "6.0.0"
rev: "6.1.0"
hooks:
- id: flake8
additional_dependencies: [flake8-docstrings]
1 change: 1 addition & 0 deletions MANIFEST.in
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ recursive-exclude docs/generated *
recursive-exclude .github *
recursive-exclude specification *

exclude .readthedocs.yaml
exclude .git-blame-ignore-revs
exclude .pre-commit-config.yaml
exclude .gitignore
Expand Down
2 changes: 1 addition & 1 deletion pybv/tests/test_bv_writer.py
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,7 @@ def test_bad_meas_date(tmpdir, meas_date, match):
)
def test_comma_in_ch_name(tmpdir, ch_names_tricky):
"""Test that writing channel names with special characters works."""
mne = pytest.importorskip("mne", minversion="0.22")
mne = pytest.importorskip("mne", minversion="1.0")
# write and read data to BV format
write_brainvision(
data=data,
Expand Down
2 changes: 1 addition & 1 deletion requirements-dev.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
numpy>=1.18.1
mne>=0.20
mne>=1.0
check-manifest
pytest
pytest-cov
Expand Down
2 changes: 2 additions & 0 deletions setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ classifiers =
Programming Language :: Python :: 3.8
Programming Language :: Python :: 3.9
Programming Language :: Python :: 3.10
Programming Language :: Python :: 3.11
Programming Language :: Python :: 3.12
project_urls =
Documentation = https://pybv.readthedocs.io
Bug Reports = https://github.com/bids-standard/pybv/issues
Expand Down