Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deno 2 upgrades and project reorganization. #2171

Closed
wants to merge 34 commits into from
Closed

Deno 2 upgrades and project reorganization. #2171

wants to merge 34 commits into from

Conversation

rwblair
Copy link
Member

@rwblair rwblair commented Oct 24, 2024

No description provided.

rwblair and others added 30 commits October 14, 2024 15:49
@rwblair
add further type checks to catching errors, and then immediately ts-i…
9d18828 
…gnore the issues.add because thats poorly typed. Update Deno.run to Deno.Command. Removes stubfile validators/isBidsy.ts.
@rwblair
bump github workflows to use deno v2
cbe29a7
@rwblair
do we really need to specify --node-modules-dir=auto for these deno c…
0c4088e 
…ommands?
@rwblair
allow-env during build step.
ff37b3a
@rwblair
why does installing std library require special permissions?
15ebfce
@rwblair
build needs to run git, set --allow-run
8877ba6
@rwblair
should of just -A'd it eh?
e6aea46
@effigies
Update .github/workflows/deno_tests.yml
0af7d7e
@rwblair
specify default import from ajv in validators/json.ts imports
a174a76
@rwblair
Merge branch 'fix/deno_2_test_and_build' of github.com:rwblair/bids-v…
d941cf6 
…alidator into fix/deno_2_test_and_build
@rwblair
revert ajv import bump version. Deno may be installing from package.j…
b67e28f 
…son though...
@rwblair
bump ajv in package.json. Will this break legacy?
dde7007
@rwblair
Revert "bump ajv in package.json. Will this break legacy?"
0b88900 
This reverts commit dde7007.
@rwblair
move legacy validator to its own directory.
fd86b31
@rwblair
working-dir -> working-directory
3ac00ad
@rwblair
more working-directory setting. fix sym link from legacy test to curr…
3331f80 
…ent tests
@rwblair
more working-directory setting. fix sym link from legacy test to curr…
d3258d2 
…ent tests
@rwblair
in progress README updates
c9ed50c
@rwblair
Merge branch 'master' of github.com:bids-standard/bids-validator into…
064fea7 
… fix/deno_2_test_and_build
@rwblair
set working directory for circleci
c87f70c
@rwblair
Merge branch 'fix/deno_2_test_and_build' of github.com:rwblair/bids-v…
e9e919c 
…alidator into fix/deno_2_test_and_build
@rwblair
deno loader back to version 11
10044b7
@rwblair
amend circle cache paths, they may not respect working-directory
efbbc77
@rwblair
working-directory -> working_directory
bc6afbb
@rwblair
fix call to get local version
8f4fd8f
@rwblair
remove circleci config
25c4bb3
@rwblair
first pass at deno dockerfile. Update docker github workflow accordin…
0c3f8a8 
…gly.
@rwblair
Revert "remove circleci config"
5f75b1e 
This reverts commit 25c4bb3.
@rwblair
Move dockerfile to base. Deno cli now handles git not existing.
6923b6f
@rwblair
empty circle jobs array
ddb0e25
@codecov Codecov
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 63.15789% with 7 lines in your changes missing coverage. Please review.

Project coverage is 89.54%. Comparing base (13c234f) to head (a77945a).

Files with missing lines Patch % Lines
bids-validator/src/version.ts 75.00% 3 Missing ⚠️
bids-validator/src/schema/associations.ts 0.00% 2 Missing ⚠️
bids-validator/src/schema/context.ts 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2171      +/-   ##
==========================================
+ Coverage   85.72%   89.54%   +3.81%     
==========================================
  Files          91       42      -49     
  Lines        3784     3271     -513     
  Branches     1221      449     -772     
==========================================
- Hits         3244     2929     -315     
+ Misses        454      333     -121     
+ Partials       86        9      -77

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies
Copy link
Collaborator

This will be done on the new repo.

@effigies effigies closed this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@effigies effigies effigies left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rwblair @effigies