Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eval): Distinguish JSON rules from sidecar rules #2031

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

effigies
Copy link
Collaborator

We currently duplicate a lot of sidecar errors for both the data file and the sidecar. This PR skips sidecar checks for sidecar files, avoids loading sidecar data for JSON files, and creates separate issue codes for missing keys in standalone JSON files (dataset_description.json, *_coordsystem.json, etc.) vs sidecar files.

@effigies effigies force-pushed the fix/sidecar-vs-json branch from 3a07bca to b0ed19f Compare July 30, 2024 13:47
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 82.85714% with 6 lines in your changes missing coverage. Please review.

Project coverage is 87.09%. Comparing base (796133c) to head (4fa9c76).

Files Patch % Lines
bids-validator/src/schema/applyRules.ts 72.72% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2031      +/-   ##
==========================================
+ Coverage   85.75%   87.09%   +1.33%     
==========================================
  Files          91      136      +45     
  Lines        3785     6449    +2664     
  Branches     1218     1550     +332     
==========================================
+ Hits         3246     5617    +2371     
- Misses        453      742     +289     
- Partials       86       90       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies
Copy link
Collaborator Author

This needs bids-standard/bids-specification#1878. Not filling in context.sidecar for JSON files helped catch some checks that were triggered on sidecar files as well as their data files.

@effigies effigies force-pushed the fix/sidecar-vs-json branch 2 times, most recently from ad36a93 to 1e72b1a Compare July 30, 2024 18:20
@effigies effigies force-pushed the fix/sidecar-vs-json branch from 8cfb6fb to 4fa9c76 Compare July 31, 2024 16:06
@rwblair rwblair merged commit 5de6cdd into bids-standard:master Jul 31, 2024
31 of 33 checks passed
@effigies effigies deleted the fix/sidecar-vs-json branch July 31, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants