-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Completely rewrite HED support #2014
Conversation
This commit completely rewrites the HED integration module to only build most objects when necessary (due to memory issues).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great --- and follows as discussed in the code walk through.
@rwblair -- this update should also allow the HED validator to be used more easily in the deno version. (The current deno version may not actually validate HED.)
This version will require package lock to hed-validator v3.15.0 (which @happy5214 is in the processing of releasing on npm).
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2014 +/- ##
==========================================
+ Coverage 85.68% 86.77% +1.09%
==========================================
Files 91 132 +41
Lines 3792 6346 +2554
Branches 1220 1522 +302
==========================================
+ Hits 3249 5507 +2258
- Misses 457 748 +291
- Partials 86 91 +5 ☔ View full report in Codecov by Sentry. |
The |
I believe this the reason that https://github.com/bids-standard/bids-validator/pull/2014 is failing. In any case, there's no advantage to having optional keys with empty or invalid contents.
Yes, it should be removed. If a |
Improve test coverage for code added in #2014
This commit completely rewrites the HED integration module to only build most objects when necessary (due to memory issues).
This depends on code in hed-validator that has not yet been released to npm, and thus it currently does not build. Please test using the
modify-bids-interface
branch of hed-validator andnpm link
.