fix: OSX and Windows tests #1989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1989 +/- ##
==========================================
+ Coverage 85.68% 87.04% +1.36%
==========================================
Files 91 131 +40
Lines 3792 6306 +2514
Branches 1220 1520 +300
==========================================
+ Hits 3249 5489 +2240
- Misses 457 726 +269
- Partials 86 91 +5 ☔ View full report in Codecov by Sentry. |
|
I switched to using POSIX joins to ensure that the internal representation of paths is POSIX. Added a test. |
OSX tests are failing because we assume temporary files exist in /tmp, while OSX has different defaults. This creates a temporary file and splits the returned path to ensure we can point to existing files.
Windows can handle both slashes and backslashes as directory separators, and tests frequently use slashes to pass paths to the OS-aware parts of the code. Using SEPARATOR_PATTERN allows us to accept either.
The internal representation of file trees uses relative paths. For simplicity, we should ensure that these always use POSIX separators.
nellh
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #1988, which resolves OSX failures.