feat(deno): Retrieve version from import.meta.url or git, when possible #1985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1985 +/- ##
=======================================
Coverage 85.68% 85.68%
=======================================
Files 91 91
Lines 3792 3792
Branches 1220 1220
=======================================
Hits 3249 3249
Misses 457 457
Partials 86 86 ☔ View full report in Codecov by Sentry. |
This comment was marked as resolved.
This comment was marked as resolved.
effigies
force-pushed
the
enh/deno-version
branch
from
98b660e to
f6665a3
Compare
effigies
changed the title
effigies
force-pushed
the
enh/deno-version
branch
from
f6665a3 to
7b85ad9
Compare
|
I think this should be good to go. |
effigies
force-pushed
the
enh/deno-version
branch
from
7b85ad9 to
961dc35
Compare
effigies
commented
Jun 8, 2024
| let version = getArchiveVersion() | ||
| if (version) { return version } | ||
|
|
||
| const url = new URL(Deno.mainModule) |
There was a problem hiding this comment.
I switched to Deno.mainModule to display a module users would expect, if we can't find any version info. Not sure if tying it to Deno is wise. Could inspect the stack trace to find the main module.
effigies
commented
Jun 8, 2024
bids-validator/src/setup/options.ts
Outdated
| '--filenameMode', | ||
| 'Enable filename checks for newline separated filenames read from stdin', | ||
| ) | ||
| async function getValidatorCommand() { |
There was a problem hiding this comment.
The return annotation caused headaches, so I dropped it, and typescript was happy enough.
effigies
force-pushed
the
enh/deno-version
branch
2 times, most recently
from
5221c61 to
c5775f2
Compare
nellh
approved these changes
Jun 10, 2024
effigies
force-pushed
the
enh/deno-version
branch
from
c165b73 to
789ff09
Compare
|
Rebased to resolve tests (I hope). |
This way git can fail and we fall back to the URL, rather than have Deno crash.
effigies
force-pushed
the
enh/deno-version
branch
from
6150a3f to
748cf3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should emit the right version for released versions on deno.land. We can improve it for untagged versions in the future.