Merge pull request #434 from chrisfilo/enh/cr_test

Test for CR new lines
bids-standard · Mar 13, 2018 · 7bd54b4 · 7bd54b4
2 parents 17caae2 + 79dc0c8
commit 7bd54b4
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/utils/issues/list.js b/utils/issues/list.js
@@ -346,5 +346,10 @@ module.exports = {
         key: 'FILENAME_COLUMN',
         severity: 'error',
         reason:   "_scans.tsv files must have a 'filename' column."
+    },
+    69: {
+        key: 'WRONG_NEW_LINE',
+        severity: 'error',
+        reason:   "All TSV files must use Line Feed '\\n' characters to denote new lines. This files uses Carriage Return '\\r'."
     }
 };
diff --git a/validators/tsv.js b/validators/tsv.js
@@ -14,6 +14,16 @@ var utils  = require('../utils');
 var TSV = function TSV (file, contents, fileList, callback) {
 
     var issues = [];
+    if ((contents.includes('\r')) && (!contents.includes('\n'))) {
+        issues.push(new Issue({
+            file: file,
+            evidence: contents,
+            code: 69
+        }));
+        callback(issues, null);
+        return;
+    }
+
     var rows = contents.split('\n');
     var headers = rows[0].split('\t');