Merge pull request #484 from chrisfilo/enh/better_error_reporting

Raise an error if fs.open fails
bids-standard · Jul 7, 2018 · 1a91b2a · 1a91b2a
2 parents 73d38b4 + 4c6c5a4
commit 1a91b2a
Showing 1 changed file with 13 additions and 8 deletions.
diff --git a/utils/files.js b/utils/files.js
@@ -248,14 +248,19 @@ function readNiftiHeader (file, callback) {
                     callback(handleGunzipError(buffer, file));
                 });
 
-            fs.open(file.path, 'r', function(status, fd) {
-                fs.read(fd, buffer, 0, bytesRead, 0, function() {
-                    if (file.name.endsWith('.nii')) {
-                        callback(parseNIfTIHeader(buffer, file));
-                    } else {
-                        decompressStream.write(buffer);
-                    }
-                });
+            fs.open(file.path, 'r', function(err, fd) {
+                if (err){
+                    callback({error: new Issue({code: 44, file: file})});
+                    return;
+                } else {
+                    fs.read(fd, buffer, 0, bytesRead, 0, function () {
+                        if (file.name.endsWith('.nii')) {
+                            callback(parseNIfTIHeader(buffer, file));
+                        } else {
+                            decompressStream.write(buffer);
+                        }
+                    });
+                }
             });
         });
     } else {