-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rf(metaschema): Validate object definitions that are JSON schema #1869
rf(metaschema): Validate object definitions that are JSON schema #1869
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1869 +/- ##
=======================================
Coverage 88.04% 88.04%
=======================================
Files 16 16
Lines 1380 1380
=======================================
Hits 1215 1215
Misses 165 165 ☔ View full report in Codecov by Sentry. |
376ac03
to
6c257f9
Compare
Validating I've got some more stuff that does catch bugs in the schema that I want to patch in after this is in. |
schema.objects.metadata
entries are very nearly JSON schema definitions. To allow BIDS validators to stand on the shoulders of JSON schema validators, the goal of this PR is to define them as JSON schema with extra fields. By doing so, BIDS validators can pass these directly to JSON schema validators along with the pieces of JSON objects that they are intended to validate.In order to do this, I've tried to formalize the different "kinds" of objects (or terms) we have in composable classes.
The main change to the schema is to rename
required_fields
torequired
, which has the same meaning in JSON schema. Similarly, we updaterecommended_fields
torecommended
, although this will have no impact on validation for now.